Fix inconsistent subscription status after cancellation with centralized cancellation logic #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
After cancelling a subscription, the status is inconsistent across different areas (#78):
Root Cause
Subscription cancellation events weren't properly synchronized between orders, subscriptions, and renewal orders. The gateway was missing status propagation logic.
Solution
Add centralized cancellation handling and status synchronization:
Unified cancellation handler - Single method to handle all cancellation scenarios (payment cancelled, billing request cancelled, subscription cancelled)
Status synchronization hooks - Ensure parent orders reflect subscription status changes and vice versa
Metadata cleanup - Clear pending payment flags when cancellation occurs
Changes
class-wc-gocardless-gateway.php
: Addhandle_subscription_cancellation()
methodclass-wc-gocardless-gateway-addons.php
: Addsync_parent_order_status()
hookTesting
Unit Test Instructions
Expected: 13/13 tests pass validating subscription cancellation logic