Skip to content

Add release-manager analysis permissions#461

Merged
0x0013 merged 2 commits into
pre-release-5.1.0from
analysis-add-rbac
Feb 6, 2026
Merged

Add release-manager analysis permissions#461
0x0013 merged 2 commits into
pre-release-5.1.0from
analysis-add-rbac

Conversation

@0x0013

@0x0013 0x0013 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

This PR implements 2 changes:

Analysis RBAC permissions

Analysis (health and rollback status for Releases) acts on Argo-Rollouts resources - AnalysisRun, AnalysisTemplate and ClusterAnalysisTemplate, thus permissions are required on those resources, if analysis feature is enabled.

The deployment of these permissions should be optional, to accommodate usage without the feature enabled.

To accomplish this, we define a new kustomization.yaml in config/with-analysis, that extends config/base with said permissions.

In our deployment code, in Kustomization definition, the following should be changed in order to add Analysis permissions:

 resources:
   - github.com/gocardless/theatre/config/crd?ref=version
-  - github.com/gocardless/theatre/config/base?ref=version
+  - github.com/gocardless/theatre/config/with-analysis?ref=version

Feedback is welcome on the location of the patched Kustomization (config/with-analysis/)

Analysis default

To preserve backwards compatibility, Analysis feature is now disabled by default.

Preserves backward compatibility, as enabling analysis requires
argo-rollouts and additional permissions.
@0x0013
0x0013 merged commit d2ab842 into pre-release-5.1.0 Feb 6, 2026
5 checks passed
@0x0013
0x0013 deleted the analysis-add-rbac branch February 6, 2026 13:54
0x0013 added a commit that referenced this pull request Mar 13, 2026
0x0013 added a commit that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants