Add release-manager analysis permissions#461
Merged
Merged
Conversation
Preserves backward compatibility, as enabling analysis requires argo-rollouts and additional permissions.
IsaacJames
approved these changes
Feb 6, 2026
0x0013
added a commit
that referenced
this pull request
Mar 13, 2026
0x0013
added a commit
that referenced
this pull request
Mar 16, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements 2 changes:
Analysis RBAC permissions
Analysis (health and rollback status for Releases) acts on Argo-Rollouts resources -
AnalysisRun,AnalysisTemplateandClusterAnalysisTemplate, thus permissions are required on those resources, if analysis feature is enabled.The deployment of these permissions should be optional, to accommodate usage without the feature enabled.
To accomplish this, we define a new
kustomization.yamlinconfig/with-analysis, that extendsconfig/basewith said permissions.In our deployment code, in Kustomization definition, the following should be changed in order to add Analysis permissions:
Feedback is welcome on the location of the patched Kustomization (
config/with-analysis/)Analysis default
To preserve backwards compatibility, Analysis feature is now disabled by default.