Use pkg/recutil in rollback controller#445
Merged
IsaacJames merged 3 commits intoJan 21, 2026
Merged
Conversation
IsaacJames
force-pushed
the
CI-3637-rollback-controller-use-recutil
branch
from
January 21, 2026 15:21
ab56fcf to
9d867e4
Compare
IsaacJames
marked this pull request as ready for review
January 21, 2026 15:46
IsaacJames
marked this pull request as draft
January 21, 2026 15:47
IsaacJames
marked this pull request as ready for review
January 21, 2026 16:09
0x0013
pushed a commit
that referenced
this pull request
Jan 29, 2026
0x0013
pushed a commit
that referenced
this pull request
Mar 13, 2026
0x0013
pushed a commit
that referenced
this pull request
Mar 16, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
goelozev
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we were implementing the release-controller we noticed that we weren't making full use of the
recutilpackage and subsequently refactored the reconcile loop (here). In this PR we're going back and refactoring the rollback controller in the same way to use therecutil.CreateOrUpdatewrapper.Note, we also discovered the Kubernetes event emitting functionality built into the logger package (https://github.com/gocardless/theatre/blob/master/pkg/logging/recorded.go). This PR also adds the
eventkey to rollback log statements to make use of this.