Release controller boilerplate - #430
Merged
Merged
Conversation
goelozev
commented
Dec 19, 2025
Comment on lines
78
to
87
| manager.GetWebhookServer().Register("/validate-releases", &admission.Webhook{ | ||
| Handler: releasewebhook.NewReleaseValidateWebhook(logger, manager.GetScheme()), | ||
| }) | ||
|
|
||
| if *enableReleaseUniquenessWebhooks { | ||
| // Webhook configuration | ||
| manager.GetWebhookServer().Register("/mutate-releases", &admission.Webhook{ | ||
| Handler: releasewebhook.NewReleaseNamerWebhook(logger, manager.GetScheme()), | ||
| }) | ||
| } |
Member
Author
There was a problem hiding this comment.
When I run the controller locally, I would comment out the webhooks config.
goelozev
marked this pull request as ready for review
December 19, 2025 10:31
0x0013
approved these changes
Dec 19, 2025
0x0013
left a comment
0x0013
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks for extracting this so quickly!
Merged
0x0013
pushed a commit
that referenced
this pull request
Jan 29, 2026
0x0013
pushed a commit
that referenced
this pull request
Mar 13, 2026
0x0013
pushed a commit
that referenced
this pull request
Mar 16, 2026
goelozev
added a commit
that referenced
this pull request
Apr 15, 2026
goelozev
added a commit
that referenced
this pull request
Apr 15, 2026
goelozev
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the release controller boilerplate + test_suite.