Update Vuemit.js #40
Merged
Update Vuemit.js #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix issues with new wp 5 where we will get `Uncaught TypeError: Vue is not a constructor`, to avoid break current setup, this should be on a new major version.
|
Hi @ctf0, thank you for taking the time to fix this. Question, how would this fix the issue? |
|
while using laravel mix which use wp5, i keep getting |
|
any news ? |
|
@ctf0 sorry, I have been really busy at work lately. Let me pull these changes tomorrow, try them out and tag the release. Thank you again! |
|
Ok, it should be good to go. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix issues with new wp 5 where we will get
Uncaught TypeError: Vue is not a constructor,note that this might break current setups, so better release a new major version.