Improving connection #323
Merged
Improving connection #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added callback function
afterOpen()to interfacedialectand call it fromConnection.Open()to handle dialect specific initial setup. (as first part of proposal #295)With this, I hope we can give dialect a change to prepare its own settings include getting server information which I already added to dialect for CockroachDB. I think it can help us to handle version different of the same database engine and service variations. (with the information from the connected server.)
Before I adding this, I made a small change to
connection.goto prevent panic on the badly configured connection.Please check this PR.