feat: silently ignore missing contentOf block #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,9 @@ import ( | |||
| <%= contentOf("buttons", {"label": "Click me"}) %> | |||
| */ | |||
| func ContentOf(name string, data hctx.Map, help hctx.HelperContext) (template.HTML, error) { | |||
| if help.Value("contentFor:"+name) == nil { | |||
There was a problem hiding this comment.
[nitpick] Consider caching the result of help.Value("contentFor:" + name) in a local variable to avoid duplicate lookups for better maintainability.
Copilot uses AI. Check for mistakes.
|
Let's continue the discussion here. The only two failed tests are those that take a default and are undefined. But if it's defined, then it works as expected. I left the tests broken for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
contentOfto silently fail when undefinedThis PR updates the
contentOfhelper to no longer throw errors on routes where thecontentForblock is not defined. Instead, it will fail silently, allowing templates to render without requiring a default value.Currently, to prevent errors, a default block must be defined for every use route, which adds unnecessary overhead and complexity. This change simplifies template development and improves developer experience.
More info:
https://gobuffalo.io/documentation/frontend-layer/helpers/#the-contentfor-and-contentof-helpers