Add missing __VERIFIER_nondet_X()s
#886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
sim642
approved these changes
Nov 7, 2022
Member
sim642
left a comment
sim642
left a comment
There was a problem hiding this comment.
I added some comments for the ones that the SV-COMP rules don't actually specify.
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Nov 25, 2022
CHANGES: Functionally equivalent to Goblint in SV-COMP 2023. * Add automatic configuration tuning (goblint/analyzer#772). * Add many library function specifications (goblint/analyzer#865, goblint/analyzer#868, goblint/analyzer#878, goblint/analyzer#884, goblint/analyzer#886). * Reorganize library stubs (goblint/analyzer#814, goblint/analyzer#845). * Add Trace Event Format output to timing (goblint/analyzer#844). * Optimize domains for address and path sets (goblint/analyzer#803, goblint/analyzer#809).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ones missing according to #868, and
__VERIFIER_nondet_int128which will be added to the rules.analyzer/lib/sv-comp/stub/src/sv-comp.c
Line 25 in 0e49d1f
I think the issue was that the typedef for
loff_tonly comes in the benchmark itself and might depend on the architecture defined for the benchmark. Although maybe all the Linux tasks have the same architecture, so we can hardcode the specific primitive type.Originally posted by @sim642 in #868 (comment)
I went with simply specifying this one via library functions to invalidate now, that should side-step this issue.