Collect constraint unknown sets in global invariant, use them for TD3 incremental load #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
cleanup
Closed
3 tasks
jerhard
reviewed
Jan 21, 2022
jerhard
reviewed
Jan 21, 2022
jerhard
reviewed
Jan 21, 2022
jerhard
reviewed
Jan 21, 2022
jerhard
reviewed
Jan 21, 2022
jerhard
reviewed
Jan 24, 2022
jerhard
reviewed
Jan 24, 2022
jerhard
approved these changes
Jan 25, 2022
This was referenced Feb 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544.
This is currently on top of #391 since there are more incremental tests, although it might be possible to rebase it against
masterinstead.As a proof of concept that this indeed works out, I refactored the incremental loading (destabilization and deletion) in TD3 to query the constraint unknowns corresponding to CFG nodes. This removes all the string-based hacks! So it's also a step towards #545.
In addition to querying the constraint unknowns of CFG nodes, it's also possible to query the constraint unknowns of a global program variable. This properly includes the base privatization, protecting locksets and accesses.
TODO