Use nodes for messages instead of locations #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karoliineh
approved these changes
Jan 14, 2022
Member
karoliineh
left a comment
karoliineh
left a comment
There was a problem hiding this comment.
Works for me.
Warning locations do move when empty lines are inserted or removed (with "load" set to true in "incremental" in the conf).
sim642
added
the
pr-dependency
sim642
removed
the
pr-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #524.
This is currently opened on top of #525 since that already adapts dead branch warnings to nodes instead of locations.
By using nodes for locations, warnings in syntactically unchanged but moved functions should move accordingly.
TODO