Fix known addresses not escaping when address set contains unknown #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any address set containing the unknown pointer returned top from the reachable query. The thread escape analysis completely ignores such escaping (it has no information, even about the addresses that were known).
This PR changes the reachable query to still return a non-top lvalue set, which contains the usual dummy as a representative for the unknown pointer, along all the known ones. This is similar to the points-to query.
Other analyses still ignore the dummy, but at least they can be a bit more sound w.r.t. to the known addresses.
This fixes the incomparability of
aget_comb01.patchwith RestartBothOnce in the interactive benchmarks.