Simplify return type of FloatDomain predicates
#1906
+173
−175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at all the
Unknowncast kinds in #1896, I realized that all theintcasts ofFloatDomainpredicate results are pointless because they are alreadyintby construction.In order to enforce this on the OCaml type level, it's better to have those predicates return
bool optioninstead ofID.t, which is implicitly assumed/required to correspond to a boolean (but inint, not_Bool).In fact this revealed that some of those operations actually were incorrectly returning
_Bool, so the cast was necessary before.This simplifies their implementations and reduces the
IntDomaindependency ofFloatDomain.I've been thinking about a similar simplification in
IntDomain, but it's a bit more involved due to the many different module interfaces.