-
Notifications
You must be signed in to change notification settings - Fork 84
Fixes/calloc #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixes/calloc #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
reviewed
Nov 24, 2020
…main if memory was zero initialised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #135:
origin, which can be eitherCallocorMalloc)calloc, which has a valueBotis actually supposed to be 0, becausecalloczero-initializes the allocated placeupdate_offsetfunction from the value domain because it's necessary to know the type of the zero which is produced bycallocCallocused to take only one argumentn * sizeand now those two are separated socalloctakesnandsizecallochave been addedeval _offsetfunction of the value domain to make possible to read 0 when something was allocated bycallocand is not initialized yetbot_value,init_vaueandtop_valuehave been moved frombaseanalysis tovalueDomain. There atop_valuefunction already existed and now, not to keep twotop_valuefunctions, a combination is kept in thevalueDomainonly (it resembles more to the one from the base analysis, which was more specific about arrays). The functionsis_mutex_typeandis_immediate_typehave been moved together because they were only used by the functions that now went to the value domain.calloctests.