Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(NOBIDS) remove slots cache as it is no longer required #2650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(NOBIDS) remove slots cache as it is no longer required #2650

wants to merge 2 commits into from

Conversation

peterbitfly
Copy link
Collaborator

@peterbitfly peterbitfly commented Oct 28, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 536e26d

Refactored the block caching mechanism for the LighthouseClient to use Redis instead of memory. This enhances the efficiency and reliability of the rpc/lighthouse.go file.

@peterbitfly peterbitfly requested a review from D13ce October 28, 2023 05:48
D13ce
D13ce previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

One addition though: I have checked all uses of func (lc *LighthouseClient) GetBlockBySlot(slot uint64) and stumbled upon func (lc *LighthouseClient) GetNewBlockChan().
Currently, this is not used and I suggest to remove it.

@peterbitfly
Copy link
Collaborator Author

lgtm

One addition though: I have checked all uses of func (lc *LighthouseClient) GetBlockBySlot(slot uint64) and stumbled upon func (lc *LighthouseClient) GetNewBlockChan(). Currently, this is not used and I suggest to remove it.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D13ce D13ce D13ce left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbitfly @D13ce