-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
tasks: delay startup signals #17769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tasks: delay startup signals #17769
Conversation
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
BeryJu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like this solution....but I dont have a better idea either
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-integrations canceled.
|
maybe a ctxvar that gets set to true after one of the startup signals have been sent? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17769 +/- ##
==========================================
+ Coverage 92.88% 92.98% +0.10%
==========================================
Files 869 869
Lines 47950 47952 +2
==========================================
+ Hits 44538 44589 +51
+ Misses 3412 3363 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is called a semaphore. 😄 |
|
looking at the tests, yeah, this is not working |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
|
that's better |
|
🍒 Cherry-pick to |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e08a84bc73e8a03fa62fe300a959fc8f3d556884
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-e08a84bc73e8a03fa62fe300a959fc8f3d556884Afterwards, run the upgrade commands from the latest release notes. |
|
|
* main: (28 commits) ci: use hashes for actions everywhere (#17803) website/integrations: fixed paperless-ngx yml syntax issue and added additional info (#17739) core, web: update translations (#17782) ci: rework internal repo (#17797) root: use hashes for dockerfile FROM (#17795) web: bump validator from 13.15.15 to 13.15.20 in /packages/prettier-config (#17776) tasks: delay startup signals (#17769) website: bump the build group in /website with 6 updates (#17712) core, web: update translations (#17660) web: bump vite from 7.1.11 to 7.1.12 in /web (#17689) website: bump validator from 13.15.15 to 13.15.20 in /website (#17741) web: bump eslint-plugin-react-hooks from 7.0.0 to 7.0.1 in /packages/eslint-config in the eslint group across 1 directory (#17714) web: bump validator from 13.15.15 to 13.15.20 in /packages/eslint-config (#17742) packages/django-postgres-cache: use upsert instead of select/update in a transaction (#17760) providers/radius: fix panic when no cert is configured (#17762) sources/oauth: Make PKCE verifier 128 characters (#17763) providers/proxy: fix missing JWT/claims header (#17759) providers/proxy: add gorm logging (#17758) web: bump the sentry group across 1 directory with 2 updates (#17743) root: Add Dockerfile label org.opencontainers.image.source (#17756) ...
There somehow is a race condition when starting up the worker, that makes some tasks inexistent even though they actually have been inserted. Here we simply delay the start of the consumers so we can completely finish the startup and only then grab tasks and process them.
Closes #17749