Skip to content

Conversation

rissson
Copy link
Member

@rissson rissson commented Sep 24, 2025

Details

needs #16978

Need to figure out how to handle:

authentik/admin/api/system.py:94: error: "HttpRequest" has no attribute "brand"  [attr-defined]
authentik/admin/api/meta.py:19: error: Incompatible types in assignment (expression has type "CharField", base class "Field" defined the type as "str | _StrPromise | None")  [assignment]
authentik/admin/tests/test_api.py:21: error: "Group" has no attribute "users"  [attr-defined]

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Sep 24, 2025
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit d5fb1e2
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68d41a5038235b0008558549
😎 Deploy Preview https://deploy-preview-16979--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit d5fb1e2
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68d41a5049b9a50008a5ecfc

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d5fb1e2
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68d41a505a7dbf00073afd23

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.79%. Comparing base (7d718a1) to head (d5fb1e2).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/admin/api/version.py 90.90% 1 Missing ⚠️
authentik/events/tasks.py 66.66% 1 Missing ⚠️
authentik/outposts/tasks.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16979      +/-   ##
==========================================
- Coverage   92.83%   92.79%   -0.05%     
==========================================
  Files         845      845              
  Lines       45675    45677       +2     
==========================================
- Hits        42403    42386      -17     
- Misses       3272     3291      +19     
Flag Coverage Δ
e2e 46.38% <60.00%> (-0.04%) ⬇️
integration 23.38% <34.44%> (-0.01%) ⬇️
unit 90.93% <96.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant