Skip to content

Conversation

dominic-r
Copy link
Member

@dominic-r dominic-r commented Sep 24, 2025

Closes: #15947

Not sure this is the best way of doing it, but let's try

@dominic-r dominic-r requested a review from a team as a code owner September 24, 2025 02:22
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 0beb3db
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68d5234cbf0e87000872d091
😎 Deploy Preview https://deploy-preview-16964--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 0beb3db
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68d5234c5d4bec0008fe38da
😎 Deploy Preview https://deploy-preview-16964--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 0beb3db
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68d5234c32fe78000878bef2
😎 Deploy Preview https://deploy-preview-16964--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.79%. Comparing base (cc61f92) to head (0beb3db).

Files with missing lines Patch % Lines
authentik/core/api/users.py 60.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16964      +/-   ##
==========================================
- Coverage   92.85%   92.79%   -0.07%     
==========================================
  Files         845      845              
  Lines       45725    45814      +89     
==========================================
+ Hits        42456    42511      +55     
- Misses       3269     3303      +34     
Flag Coverage Δ
e2e 46.35% <5.20%> (-0.05%) ⬇️
integration 23.28% <5.20%> (-0.10%) ⬇️
unit 90.93% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r dominic-r force-pushed the sdko/sa-input-validation branch 2 times, most recently from 93ddeed to 8952dd5 Compare September 24, 2025 02:52
@BeryJu BeryJu requested a review from a team as a code owner September 24, 2025 11:27
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@dominic-r dominic-r force-pushed the sdko/sa-input-validation branch from 6d94576 to 467f723 Compare September 24, 2025 23:55
@dominic-r dominic-r requested a review from BeryJu September 25, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAs can be created without username (mandatory field issue)
2 participants