Skip to content

web: Fix issue where clicking a list item scrolls container. #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

GirlBossRush
Copy link
Contributor

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@GirlBossRush GirlBossRush requested a review from a team as a code owner August 13, 2025 20:11
Copy link

netlify bot commented Aug 13, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 7dd79e1
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/689cf18139153d00087ae4db
😎 Deploy Preview https://deploy-preview-16174--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 13, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 7dd79e1
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/689cf181a533a20008e7d539
😎 Deploy Preview https://deploy-preview-16174--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 13, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 7dd79e1
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/689cf181145489000844c463

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.76%. Comparing base (dbe7bfe) to head (7dd79e1).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16174      +/-   ##
==========================================
+ Coverage   92.46%   92.76%   +0.30%     
==========================================
  Files         836      836              
  Lines       45167    45167              
==========================================
+ Hits        41763    41901     +138     
+ Misses       3404     3266     -138     
Flag Coverage Δ
e2e 46.60% <ø> (+1.16%) ⬆️
integration 23.59% <ø> (+<0.01%) ⬆️
unit 90.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.

@GirlBossRush GirlBossRush merged commit c886e4f into main Aug 13, 2025
153 of 155 checks passed
@GirlBossRush GirlBossRush deleted the fix-list-scroll-jump branch August 13, 2025 21:30
Comment on lines +160 to +162
* @todo
* This doesn't quite work as intended, but this component will likely
* be refined after the PatternFly upgrade.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO related to issue #12332 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants