-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
web: Docker versioning compatibility #16139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/cherry-pick version-2025.6 |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16139 +/- ##
==========================================
- Coverage 92.82% 92.81% -0.01%
==========================================
Files 836 836
Lines 45166 45167 +1
==========================================
- Hits 41926 41923 -3
- Misses 3240 3244 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-49590ef1a9f2fa8a4b81f2941143470b1f36ae46
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-49590ef1a9f2fa8a4b81f2941143470b1f36ae46 Afterwards, run the upgrade commands from the latest release notes. |
return static_loader(path.replace("%v", authentik_full_version())) | ||
"""Wrapper around {% static %} tag that appends a version query parameter to the URL""" | ||
|
||
return static_loader(path) + "?v=" + authentik_full_version() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in particular is the crux of it. The value of authentik_full_version
within the Docker image isn't accessible from ESBuild, but all we're hoping to achieve here is ensure that static assets have cache busting between version upgrades.
This function might be a good candidate for Django path objects, making it possible to do thing like subresource integrity and CSP nonces
0a390fa
to
47e5beb
Compare
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
47e5beb
to
2d34514
Compare
Details
This PR updates the frontend only setup to be compatible with the latest changes to our versioning. This achieved with a combination of more accurate version parsing, and fixing an edge case where the ESBuild's versioned assets can't align with the version embedded in Docker images.