core: Mark impersonation reason field as required in UI and fix status codes #16065
+24
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-integrations canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dominic-r
force-pushed
the
sdko/impersonation-diag
branch
from
e9a1879 to
f671fb7
Compare
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BeryJu
reviewed
Aug 11, 2025
BeryJu
changed the title
dominic-r
force-pushed
the
sdko/impersonation-diag
branch
from
f671fb7 to
b8b94d5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16065 +/- ##
==========================================
+ Coverage 92.39% 92.72% +0.33%
==========================================
Files 837 837
Lines 45244 45244
==========================================
+ Hits 41802 41954 +152
+ Misses 3442 3290 -152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dominic R dominic@sdko.org
Closes: #15991
Updates the Impersonation modal to have the reason field marked as mandatory when necessary as well as updating the API to return a 400 by raising a validationerror when the reason is not set and the tenant requires an impersonation reason.