-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
sources/saml: add default error messages to exceptions #15562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15562 +/- ##
=======================================
Coverage 93.15% 93.16%
=======================================
Files 831 831
Lines 44135 44146 +11
=======================================
+ Hits 41114 41127 +13
+ Misses 3021 3019 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
09c63fb
to
64a7421
Compare
64a7421
to
c32c9cc
Compare
Thank you for fixing this issue. |
Anytime @cheggerdev |
We don't cherry pick those sort of changes to previous versions. |
It would be really nice and helpful when this will go into 2025.8 |
The 2025.8 branch has been opened. Can this PR go into it, please ? |
@cheggerdev are you running into a SAML error right now that you need this to debug? If you message me on discord, I can try and help you debug your problem. I've played with zabbix a bit while testing some integrations so I might have a little context |
@ConzorKingKong I still run into a SAML error. |
Details
Gives default message for saml exceptions and allows for adding custom error messages as well
closes #13598
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)