Skip to content

sources/saml: add default error messages to exceptions #15562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ConzorKingKong
Copy link
Contributor

Details

Gives default message for saml exceptions and allows for adding custom error messages as well

closes #13598

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@ConzorKingKong ConzorKingKong requested a review from a team as a code owner July 15, 2025 01:30
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6877ca55dfde040008ea6686

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6877ca55dc24cb0008bbedfa

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6877ca55be55110008933124
😎 Deploy Preview https://deploy-preview-15562--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.16%. Comparing base (f836c38) to head (c32c9cc).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15562   +/-   ##
=======================================
  Coverage   93.15%   93.16%           
=======================================
  Files         831      831           
  Lines       44135    44146   +11     
=======================================
+ Hits        41114    41127   +13     
+ Misses       3021     3019    -2     
Flag Coverage Δ
e2e 46.63% <100.00%> (-0.01%) ⬇️
integration 23.48% <0.00%> (-0.02%) ⬇️
unit 91.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rissson rissson changed the title sources/saml add default error messages to exceptions sources/saml: add default error messages to exceptions Jul 15, 2025
@cheggerdev
Copy link

Thank you for fixing this issue.

@ConzorKingKong
Copy link
Contributor Author

Anytime @cheggerdev

@cheggerdev
Copy link

cheggerdev commented Jul 23, 2025

@rissson @BeryJu Please review this PR

Would you mind to cherry-pick this to 2025.6.x release branch ?

@rissson
Copy link
Member

rissson commented Jul 23, 2025

We don't cherry pick those sort of changes to previous versions.

@cheggerdev
Copy link

We don't cherry pick those sort of changes to previous versions.

It would be really nice and helpful when this will go into 2025.8

@cheggerdev
Copy link

The 2025.8 branch has been opened. Can this PR go into it, please ?

@ConzorKingKong
Copy link
Contributor Author

ConzorKingKong commented Aug 18, 2025

@cheggerdev are you running into a SAML error right now that you need this to debug? If you message me on discord, I can try and help you debug your problem. I've played with zabbix a bit while testing some integrations so I might have a little context

@cheggerdev
Copy link

cheggerdev commented Aug 18, 2025

@cheggerdev are you running into a SAML error right now that you need this to debug? If you message me on discord — peshekdotdev — I can try and help you debug your problem. I've played with zabbix a bit while testing some integrations so I might have a little context

@ConzorKingKong I still run into a SAML error.
I use a Let's Encrypt certificate issued with acme.sh --ecc.
My current theory is that authentik saml cannot deal with ECC certificates but with RSA only. See issue #15412
authentik oauth works with ECC certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAMLException unclear because of empty string.
3 participants