stages/authenticator_webauthn: add option to configure max attempts #15041
Conversation
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #15041 +/- ##
==========================================
+ Coverage 92.77% 92.83% +0.05%
==========================================
Files 815 815
Lines 42117 42156 +39
==========================================
+ Hits 39073 39134 +61
+ Misses 3044 3022 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BeryJu
force-pushed
the
stages/authenticator_webauthn/max-attempts
branch
from
06b1c2d to
74320c4
Compare
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-74320c45953633c9af587066612bc8b144713fe3
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-74320c45953633c9af587066612bc8b144713fe3Afterwards, run the upgrade commands from the latest release notes. |
| from authentik.stages.authenticator_webauthn.utils import get_origin, get_rp_id | ||
|
|
||
| LOGGER = get_logger() | ||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
Not to lower the morale but can authentik switch to a real language please? :)))
| @@ -84,6 +84,8 @@ class AuthenticatorWebAuthnStage(ConfigurableStage, FriendlyNamedStage, Stage): | |||
|
|
|||
| device_type_restrictions = models.ManyToManyField("WebAuthnDeviceType", blank=True) | |||
|
|
|||
| max_attempts = models.PositiveIntegerField(default=0) | |||
There was a problem hiding this comment.
null=True instead of treating 0 as Infinity?
(Then this can be a real _Positive_IntegerField)
There was a problem hiding this comment.
I would do that but the API schema then turns it into number | undefined | null which is annoying to deal with in the UI
…oauthentik#15041) * house keeping - migrate to session part 1 Signed-off-by: Jens Langhammer <jens@goauthentik.io> * cleanup v2 Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add max_attempts Signed-off-by: Jens Langhammer <jens@goauthentik.io> * teeny tiny cleanup Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add ui Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Details
Some cleanup and add the option to limit the max webauthn registration attempts
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)