Skip to content

web: Clean up usage of server injected values. #14118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GirlBossRush
Copy link
Contributor

Details

This PR fixes a collection of issues surrounding inconsistent usage of server injected values, such as the authentik config, UI config, etc.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush self-assigned this Apr 17, 2025
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 29a3117
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/681562e1a5eade0008007937

@GirlBossRush GirlBossRush marked this pull request as ready for review April 17, 2025 04:55
@GirlBossRush GirlBossRush requested review from a team as code owners April 17, 2025 04:55
@GirlBossRush GirlBossRush changed the base branch from template-format to main April 17, 2025 13:14
@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch from b80dd13 to 49bd209 Compare April 17, 2025 13:16
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 29a3117
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/681562e16b018200080a4f3c

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (f70635c) to head (29a3117).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14118      +/-   ##
==========================================
- Coverage   92.76%   92.70%   -0.07%     
==========================================
  Files         809      809              
  Lines       41533    41532       -1     
==========================================
- Hits        38529    38503      -26     
- Misses       3004     3029      +25     
Flag Coverage Δ
e2e 47.77% <100.00%> (-0.14%) ⬇️
integration 24.39% <0.00%> (+<0.01%) ⬆️
unit 90.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch from f122dd3 to 8756687 Compare April 17, 2025 14:14
Copy link
Contributor

github-actions bot commented Apr 17, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-29a3117a94226fc2cb01dc6ea7022598826a7d19
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-29a3117a94226fc2cb01dc6ea7022598826a7d19

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch 7 times, most recently from 11ed805 to a27358e Compare April 22, 2025 14:40
@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch from a27358e to 198e1b8 Compare May 3, 2025 00:23
@GirlBossRush GirlBossRush requested a review from a team as a code owner May 3, 2025 00:23
@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch from 198e1b8 to afe4e09 Compare May 3, 2025 00:26
web: Format.

web: Disable sentry via server context.
@GirlBossRush GirlBossRush force-pushed the server-context-cleanup branch from afe4e09 to 29a3117 Compare May 3, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant