Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/user: fix post MFA creation link being invalid #13157

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 21, 2025

Details

Fix incorrect link being generated post-MFA device enrollment


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 21, 2025 13:49
@BeryJu
Copy link
Member Author

BeryJu commented Feb 21, 2025

/cherry-pick version-2025.2

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit ce5467f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b8847683a81e00078b8c84
😎 Deploy Preview https://deploy-preview-13157--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit ce5467f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b884766c87d90008ea4f4b

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (6da0548) to head (ce5467f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13157   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         792      792           
  Lines       40229    40229           
=======================================
+ Hits        37294    37296    +2     
+ Misses       2935     2933    -2     
Flag Coverage Δ
e2e 48.10% <ø> (+<0.01%) ⬆️
integration 24.12% <ø> (ø)
unit 90.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ce5467f77c105f644aa37772cb57f8caa1470b4d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ce5467f77c105f644aa37772cb57f8caa1470b4d

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit d98523f into main Feb 21, 2025
90 checks passed
@BeryJu BeryJu deleted the web/user/fix-post-mfa-link branch February 21, 2025 15:43
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 21, 2025
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Feb 21, 2025
… (#13159)

web/user: fix post MFA creation link being invalid (#13157)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant