-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
web: fix scrollbar styling #12600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: fix scrollbar styling #12600
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12600 +/- ##
=======================================
Coverage 92.75% 92.76%
=======================================
Files 794 794
Lines 40545 40545
=======================================
+ Hits 37609 37610 +1
+ Misses 2936 2935 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@RoboMagus : Quick question; where would I go in the UI to observe the changes you made? |
See linked issue #11936 |
I tested this and it works as expected, no unnecessary scrollbars in Firefox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but what does it mean if the browser doesn't support @supports
?
@kensternberg-authentik seems that's pretty well supported in all major browsers, probably many other things also could be broken in a really old browser |
* main: (49 commits) core: bump uvicorn from 0.34.1 to v0.34.2 (#14175) website/integrations: add xcreds (#14163) core, web: update translations (#14179) web: update default flow background (#14115) web: bump API Client version (#14176) enterprise/policies: Add Password Uniqueness History Policy (#13453) web/xliff: fix duplicated translations (#14164) website/docs: fix postgres pool recommended settings (#14149) core: bump astral-sh/uv from 0.6.14 to 0.6.16 (#14161) web: fix scrollbar styling (#12600) website: integrations: gravity: fix issuer URL (#14155) web: Packagify live reload plugin. (#14134) web: bump API Client version (#14062) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#14146) translate: Updates for file web/xliff/en.xlf in zh_CN (#14145) core: bump goauthentik.io/api/v3 from 3.2025024.7 to 3.2025024.8 (#14143) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#14144) translate: Updates for file web/xliff/en.xlf in zh-Hans (#14139) core, web: update translations (#14142) core: bump yarl from 1.19.0 to v1.20.0 (#14128) ...
Details
Closes #11936.
This PR removes unnecessary scrollbars on the
.pf-c-card__body
class, as well as add scrollbar styling to browsers that do not support the::-webkit-scrollbar
. (Currently on Firefox thick unstyled grey scrollbars show up whenever a container is scrollable)Note that this only changes the color scheme, as scrollbar thickness styling is not inherited (see this issue) and therefore would require modifying a significant number of classes to add
scrollbar-width
.Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)