Skip to content

website/integrations: Semaphore #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 2, 2025
Merged

website/integrations: Semaphore #12515

merged 20 commits into from
Jan 2, 2025

Conversation

nicedevil007
Copy link
Contributor

Details

Created the documentation for Semaphore UI.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

nicedevil007 and others added 5 commits December 30, 2024 09:40
@nicedevil007
Initial start of Semaphore UI docs
c093f46 
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007
Added Semaphore UI docs link
4230021 
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007
Changed to mdx format
0d6183f
@nicedevil007
Ran make lint-fix, make web and make website
6ba7900
@nicedevil007
Merge branch 'semaphore' of https://github.com/nicedevil007/authentik …
332f41f 
…into semaphore
@nicedevil007 nicedevil007 requested a review from a team as a code owner December 30, 2024 09:30
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit af84df3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6774eb97d6d4bc00088be777
😎 Deploy Preview https://deploy-preview-12515--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit af84df3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6774eb970a013b0008699cac
😎 Deploy Preview https://deploy-preview-12515--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (91145b7) to head (af84df3).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12515      +/-   ##
==========================================
- Coverage   92.76%   92.70%   -0.07%     
==========================================
  Files         770      770              
  Lines       38859    38873      +14     
==========================================
- Hits        36047    36036      -11     
- Misses       2812     2837      +25
Flag Coverage Δ
e2e 48.65% <ø> (-0.11%) ⬇️
integration 24.58% <ø> (-0.01%) ⬇️
unit 90.38% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nicedevil007 and others added 3 commits December 30, 2024 09:39
@nicedevil007
Added sidebar entry
18d288d
@nicedevil007
added sidebar integration
69a1673
@nicedevil007
now fixed sidebar integration
bceb904 
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@BeryJu BeryJu changed the title Semaphore website/integrations: Semaphore Dec 30, 2024
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
website/integrations/services/semaphore/index.mdx Outdated
- `authentik.company` is the FQDN of the authentik install.
- `ak.cert` is the self-signed certificate that will be used for the service provider.

## Semaphore UI configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to title this "authentik configuration"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @nicedevil007 help me understand this one.. don't we want line 24 to be "authentik configuration", because this section is about creating the app and provider in authentik. Then line 45 is the Semaphore section, no?

tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry reviewed Dec 30, 2024
View reviewed changes
tanberry
tanberry requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @nicedevil007 for adding this integration guide! A few requested edits, please, then let's merge!

dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
dominic-r
dominic-r reviewed Dec 30, 2024
View reviewed changes
@dominic-r
Copy link
Contributor

dominic-r commented Dec 30, 2024 •
edited
Loading

Just a few little nits as tana likes to say. Thanks for your contribution!

nicedevil007 and others added 11 commits December 31, 2024 09:16
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
07de32a 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
e76f1e3 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
edc8eb7 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
81ad6ed 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
e0ed36e 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
012217e 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @tanberry
Update website/integrations/services/semaphore/index.mdx
3eeeb0d 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @dominic-r
Update website/integrations/services/semaphore/index.mdx
b81d791 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @dominic-r
Update website/integrations/services/semaphore/index.mdx
97776e8 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 @dominic-r
Update website/integrations/services/semaphore/index.mdx
2b84156 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007
Update to Feedback on PR ;)
3b27f55 
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007
Copy link
Contributor Author

thank you again for helping me out with my doc PR :) I hope the changes I made make more sense now.

@tanberry
Copy link
Contributor

Hi @nicedevil007 I accidentally added a comment to your comit instead of this PR... we still need to change the first (and duplicate) title "Semaphore configuration" (line 24?) to say "authentik configuration". Otherwise, looks good!

@nicedevil007
Title…
af84df3 
Ahhh now I got what you were trying to Tell me on the last comment 😂 happy new year ✌️
tanberry
tanberry approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @nicedevil007 !

@tanberry tanberry merged commit 27baedf into goauthentik:main Jan 2, 2025
68 checks passed
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
@kensternberg-authentik
Merge branch 'main' into dev
be349e2 
* main:
  core: bump github.com/getsentry/sentry-go from 0.30.0 to 0.31.1 (#12543)
  core: bump google-api-python-client from 2.156.0 to 2.157.0 (#12544)
  core: bump ruff from 0.8.4 to 0.8.5 (#12545)
  core: bump msgraph-sdk from 1.15.0 to 1.16.0 (#12546)
  Update index.mdx (#12542)
  web: fix source selection and outpost integration health (#12530)
  Ading a step to paperless guide (#12539)
  website/integrations: Semaphore (#12515)
  website/integrations: komga: document (#12476)
  website/integrations: fix missing quote in paperless-ngx (#12537)
  website/integrations: cloudflare access: upd placeholder for saas (#12536)
  website/integrations: veeam-enterprise-manager: don't hardcode helpcenter doc version (#12538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanberry tanberry tanberry approved these changes

+1 more reviewer

@dominic-r dominic-r dominic-r left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicedevil007 @dominic-r @tanberry