Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: fix incorrect object_description for object-level permissions #12029

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 14, 2024

Details

closes #11579


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 14, 2024 17:53
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 26f7469
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/673639195882e100085f12fd

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 26f7469
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6736391a2203490008abddca
😎 Deploy Preview https://deploy-preview-12029--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu
Copy link
Member Author

BeryJu commented Nov 14, 2024

/cherry-pick version-2024.10

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (bcb91d2) to head (26f7469).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12029      +/-   ##
==========================================
- Coverage   92.66%   92.60%   -0.06%     
==========================================
  Files         761      761              
  Lines       37863    37863              
==========================================
- Hits        35085    35063      -22     
- Misses       2778     2800      +22     
Flag Coverage Δ
e2e 49.15% <0.00%> (-0.12%) ⬇️
integration 24.90% <0.00%> (ø)
unit 90.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-26f7469e9a2dbe6e6bfc5002c541fce716299468
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-26f7469e9a2dbe6e6bfc5002c541fce716299468-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-26f7469e9a2dbe6e6bfc5002c541fce716299468

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-26f7469e9a2dbe6e6bfc5002c541fce716299468-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 0bdef2a into main Nov 15, 2024
66 checks passed
@BeryJu BeryJu deleted the rbac/fix-incorrect-object_description branch November 15, 2024 13:21
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 15, 2024
…12029)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 15, 2024
…cherry-pick #12029) (#12043)

rbac: fix incorrect object_description for object-level permissions (#12029)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant