Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: mastodon: set correct uid field #11945

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Nov 7, 2024

Setting the OIDC_UID_FIELD as sub created users on Mastodon with random usernames. Once this was changed to preferred_username, new users were created with their usernames set in authentik. My assumption is that users would wish to have the same username rather than have a random one generated.

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Setting the `OIDC_UID_FIELD` as `sub` created users on Mastodon with random usernames. Once this was changed to `preferred_username`, new users were created with their usernames set in authentik. My assumption is that users would wish to have the same username rather than have a random one generated.

Signed-off-by: 4d62 <github-user@sdko.org>
@4d62 4d62 requested a review from a team as a code owner November 7, 2024 01:45
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f641110
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6732b6a02104bb00082ca18b
😎 Deploy Preview https://deploy-preview-11945--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit f641110
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6732b6a0c3d234000878d08d
😎 Deploy Preview https://deploy-preview-11945--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (b2c9dff) to head (f641110).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11945      +/-   ##
==========================================
+ Coverage   92.58%   92.63%   +0.05%     
==========================================
  Files         761      761              
  Lines       37822    37822              
==========================================
+ Hits        35016    35038      +22     
+ Misses       2806     2784      -22     
Flag Coverage Δ
e2e 49.30% <ø> (+0.09%) ⬆️
integration 24.91% <ø> (ø)
unit 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but there should be a warning that https://docs.goauthentik.io/docs/sys-mgmt/settings#allow-users-to-change-username should be set to false (which is the default but still) when using preferred_username as the primary identifier

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a suggestion... instead of removing info, we can add info (by showing both).

@4d62 4d62 requested review from tanberry and BeryJu November 12, 2024 01:56
@4d62
Copy link
Contributor Author

4d62 commented Nov 12, 2024

Not sure if I put that at the right place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants