Skip to content

sources/kerberos: use new python-kadmin implementation #11932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

rissson
Copy link
Member

@rissson rissson commented Nov 5, 2024

Details


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit ddc7c05
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/673368a986ed3800084e56d4

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ddc7c05
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/673368a94fe7260008c0449a

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (05b5987) to head (ddc7c05).
Report is 28 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/kerberos/models.py 62.50% 3 Missing ⚠️
authentik/sources/kerberos/signals.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11932      +/-   ##
==========================================
- Coverage   92.65%   92.63%   -0.02%     
==========================================
  Files         761      761              
  Lines       37813    37841      +28     
==========================================
+ Hits        35035    35055      +20     
- Misses       2778     2786       +8     
Flag Coverage Δ
e2e 49.29% <41.17%> (+0.02%) ⬆️
integration 24.91% <41.17%> (-0.01%) ⬇️
unit 90.15% <76.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ddc7c05d7d3a5dc7bd96a40ab0158815c62bf8bd
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ddc7c05d7d3a5dc7bd96a40ab0158815c62bf8bd-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ddc7c05d7d3a5dc7bd96a40ab0158815c62bf8bd

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ddc7c05d7d3a5dc7bd96a40ab0158815c62bf8bd-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson force-pushed the kadmin-use-rewrite branch from 77b9d9f to dfee490 Compare November 6, 2024 19:35
@rissson rissson marked this pull request as ready for review November 6, 2024 19:35
@rissson rissson requested a review from a team as a code owner November 6, 2024 19:35
@rissson rissson marked this pull request as draft November 8, 2024 20:14
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson force-pushed the kadmin-use-rewrite branch from dfee490 to 155f243 Compare November 9, 2024 18:14
@rissson rissson marked this pull request as ready for review November 9, 2024 18:15
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson merged commit eb9d8c2 into main Nov 12, 2024
66 of 67 checks passed
@rissson rissson deleted the kadmin-use-rewrite branch November 12, 2024 14:59
kensternberg-authentik added a commit that referenced this pull request Nov 12, 2024
* main: (21 commits)
  web: bump API Client version (#11997)
  sources/kerberos: use new python-kadmin implementation (#11932)
  core: add ability to provide reason for impersonation (#11951)
  website/integrations:  update vcenter integration docs (#11768)
  core, web: update translations (#11995)
  website: bump postcss from 8.4.48 to 8.4.49 in /website (#11996)
  web: bump API Client version (#11992)
  blueprints: add default Password policy (#11793)
  stages/captcha: Run interactive captcha in Frame (#11857)
  core, web: update translations (#11979)
  core: bump packaging from 24.1 to 24.2 (#11985)
  core: bump ruff from 0.7.2 to 0.7.3 (#11986)
  core: bump msgraph-sdk from 1.11.0 to 1.12.0 (#11987)
  website: bump the docusaurus group in /website with 9 updates (#11988)
  website: bump postcss from 8.4.47 to 8.4.48 in /website (#11989)
  stages/password: use recovery flow from brand (#11953)
  core: bump golang.org/x/sync from 0.8.0 to 0.9.0 (#11962)
  web: bump cookie, swagger-client and express in /web (#11966)
  core, web: update translations (#11959)
  core: bump debugpy from 1.8.7 to 1.8.8 (#11961)
  ...
kensternberg-authentik added a commit that referenced this pull request Nov 13, 2024
* main: (55 commits)
  web: bump API Client version (#11997)
  sources/kerberos: use new python-kadmin implementation (#11932)
  core: add ability to provide reason for impersonation (#11951)
  website/integrations:  update vcenter integration docs (#11768)
  core, web: update translations (#11995)
  website: bump postcss from 8.4.48 to 8.4.49 in /website (#11996)
  web: bump API Client version (#11992)
  blueprints: add default Password policy (#11793)
  stages/captcha: Run interactive captcha in Frame (#11857)
  core, web: update translations (#11979)
  core: bump packaging from 24.1 to 24.2 (#11985)
  core: bump ruff from 0.7.2 to 0.7.3 (#11986)
  core: bump msgraph-sdk from 1.11.0 to 1.12.0 (#11987)
  website: bump the docusaurus group in /website with 9 updates (#11988)
  website: bump postcss from 8.4.47 to 8.4.48 in /website (#11989)
  stages/password: use recovery flow from brand (#11953)
  core: bump golang.org/x/sync from 0.8.0 to 0.9.0 (#11962)
  web: bump cookie, swagger-client and express in /web (#11966)
  core, web: update translations (#11959)
  core: bump debugpy from 1.8.7 to 1.8.8 (#11961)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants