Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: 2024.10.1 Release Notes #11926

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

gergosimonyi
Copy link
Collaborator

Using details may be a bit weird. An alternative is a h3.

@gergosimonyi gergosimonyi requested a review from a team as a code owner November 5, 2024 15:45
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 287ee61
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/672a490869033d0008981ad4

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 287ee61
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/672a4907f2f9ab0008669b5e
😎 Deploy Preview https://deploy-preview-11926--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (b44b5c1) to head (287ee61).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11926      +/-   ##
==========================================
- Coverage   92.64%   92.57%   -0.07%     
==========================================
  Files         761      761              
  Lines       37813    37813              
==========================================
- Hits        35030    35005      -25     
- Misses       2783     2808      +25     
Flag Coverage Δ
e2e 49.11% <ø> (-0.11%) ⬇️
integration 24.91% <ø> (ø)
unit 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-287ee61f80099e7133c8b4d4965c758aeb0bc691
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-287ee61f80099e7133c8b4d4965c758aeb0bc691-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-287ee61f80099e7133c8b4d4965c758aeb0bc691

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-287ee61f80099e7133c8b4d4965c758aeb0bc691-arm64

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my thoughts about the "construction" of the API section.

Even though I think that collapsible sections are fantastic for giving pages a clean look, and improving visual scanabilty, there are two reasons I am not keen to use the <details open> element:

  1. when collapsed, the content is not searchable on Firefox and Safari (though we could have it open by default, then allow the reader to collapse the section if they want)
  2. the background colour of the section, when opened, is kinda jarring with the rest of the page (minor CSS fix probably).

So I prefer Grego's approach of using H3's. (And making those H3s much more specific, for both scanability and for SEO.)

My biggest takeaway from this is that I don't think we should be cramming patch release info into the major version's Release Notes. The 3 or 4 changes in the .1 patch release are hard to find amongst all of the .0 release info, and in general it doesn't seem right to edit/modify existing release notes. Let's just make a new short RN doc for each patch release. That would help our readers quickly determined what is actually in the patch release. ;-)

@gergosimonyi
Copy link
Collaborator Author

/cherry-pick version-2024.10

@gergosimonyi gergosimonyi merged commit 821e296 into main Nov 5, 2024
65 checks passed
@gergosimonyi gergosimonyi deleted the website/docs/2024.10.1-release-notes branch November 5, 2024 17:04
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 5, 2024
* fix API Changes in `2024.10` changelog

* add `2024.10.1` API Changes to changelog

* add changes in `2024.10.1` to changelog

* change `details` to `h3` in changelog
gergosimonyi added a commit that referenced this pull request Nov 5, 2024
website/docs: `2024.10.1` Release Notes (#11926)

* fix API Changes in `2024.10` changelog

* add `2024.10.1` API Changes to changelog

* add changes in `2024.10.1` to changelog

* change `details` to `h3` in changelog

Co-authored-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com>
kensternberg-authentik added a commit that referenced this pull request Nov 12, 2024
* main:
  website/docs: fix slug matching redirect URI causing broken refresh (#11950)
  website/integrations: jellyfin: update plugin catalog location (#11948)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#11942)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#11946)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#11947)
  website/docs: clarify traefik ingress setup (#11938)
  core: bump importlib-metadata from 8.4.0 to 8.5.0 (#11934)
  web: bump API Client version (#11930)
  root: backport version bump `2024.10.1` (#11929)
  website/docs: `2024.10.1` Release Notes (#11926)
  website: bump path-to-regexp from 1.8.0 to 1.9.0 in /website (#11924)
  core: bump sentry-sdk from 2.17.0 to 2.18.0 (#11918)
  website: bump the docusaurus group in /website with 9 updates (#11917)
  core: bump goauthentik.io/api/v3 from 3.2024100.1 to 3.2024100.2 (#11915)
  core, web: update translations (#11914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants