Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: revert lockfile lint, re-add integrity #11380

Merged
merged 1 commit into from
Sep 14, 2024
Merged

web: revert lockfile lint, re-add integrity #11380

merged 1 commit into from
Sep 14, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 14, 2024

Details

closes #11169


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner September 14, 2024 20:34
Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 0652a84
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66e5facd9fae220008f5b3e9

Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 0652a84
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66e5facdc4b06a0008bd7324
😎 Deploy Preview https://deploy-preview-11380--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu
Copy link
Member Author

BeryJu commented Sep 14, 2024

/cherry-pick version-2024.8

(I already know this cherry pick is gonna fail)

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (ebf3913) to head (0652a84).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11380      +/-   ##
==========================================
- Coverage   92.73%   92.66%   -0.08%     
==========================================
  Files         736      736              
  Lines       36490    36490              
==========================================
- Hits        33840    33814      -26     
- Misses       2650     2676      +26     
Flag Coverage Δ
e2e 49.14% <ø> (-0.11%) ⬇️
integration 24.97% <ø> (ø)
unit 90.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

github-actions bot commented Sep 14, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0652a84ef75a9b89d78df0c60a4f196708f98fe1
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0652a84ef75a9b89d78df0c60a4f196708f98fe1-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-0652a84ef75a9b89d78df0c60a4f196708f98fe1

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-0652a84ef75a9b89d78df0c60a4f196708f98fe1-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 02d8f82 into main Sep 14, 2024
60 checks passed
@BeryJu BeryJu deleted the web/fix-lock branch September 14, 2024 21:12
Copy link
Contributor

Cherry-pick failed with Merge error 02d8f82a5e848f5db0ea783797508ac97c1cf41c into temp-cherry-pick-d15a8c-version-2024.8

BeryJu added a commit that referenced this pull request Sep 14, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
# Conflicts:
#	web/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide package-lock.json with fully resolved dependencies again
1 participant