Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: gitea: fix helm values #10043

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

IslamHeggy
Copy link
Contributor

@IslamHeggy IslamHeggy commented Jun 9, 2024

Details

This is a simple PR that includes fixing a typo in the documentation which took me an hour to fix on my own. So I am fixing this so it might help others to save time at some point!

Issue #10042 includes the problem with screenshots.

Closes #10042


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Islam Heggy <islam.heggy@gmail.com>
@IslamHeggy IslamHeggy requested a review from a team as a code owner June 9, 2024 19:07
Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit cc28670
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6665fd8182ab2c0008ffa3b2

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit cc28670
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6665fd81e16d8000089c3eea
😎 Deploy Preview https://deploy-preview-10043--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IslamHeggy
Copy link
Contributor Author

Maybe it can be better to include some kind of automation to automatically fetch yaml values from helm charts and add it to Markdown for better maintainability

@rissson rissson changed the title docs: Update gitea helm intergration value website/integrations: gitea: fix helm values Jun 10, 2024
@rissson
Copy link
Member

rissson commented Jun 10, 2024

Thank you for your contribution!

@rissson rissson enabled auto-merge (squash) June 10, 2024 09:08
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (993fc4b) to head (cc28670).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10043      +/-   ##
==========================================
- Coverage   92.64%   92.63%   -0.01%     
==========================================
  Files         713      713              
  Lines       34878    34878              
==========================================
- Hits        32313    32310       -3     
- Misses       2565     2568       +3     
Flag Coverage Δ
e2e 49.64% <ø> (-0.01%) ⬇️
integration 25.47% <ø> (ø)
unit 90.10% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit 31b8914 into goauthentik:main Jun 10, 2024
59 of 65 checks passed
kensternberg-authentik added a commit that referenced this pull request Jun 11, 2024
* main: (66 commits)
  rbac: filters: fix missing attribute for unauthenticated requests (#10061)
  tests/e2e: docker-compose.yml: remove version element forgotten last time (#10067)
  providers/microsoft_entra: fix error when updating connection attributes (#10039)
  website/integrations: aws: fix about service link (#10062)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in it (#10060)
  core: bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3 (#10046)
  core: bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 (#10047)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10058)
  core: bump sentry-sdk from 2.5.0 to 2.5.1 (#10048)
  core: bump django-cte from 1.3.2 to 1.3.3 (#10049)
  core: bump packaging from 24.0 to 24.1 (#10050)
  web: bump yaml from 2.4.3 to 2.4.5 in /web (#10054)
  web: bump @sentry/browser from 8.7.0 to 8.8.0 in /web in the sentry group (#10051)
  web: bump esbuild from 0.21.4 to 0.21.5 in /web (#10053)
  crypto: update fingerprint at same time as certificate (#10036)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10056)
  website/integrations: gitea: fix helm values (#10043)
  core, web: update translations (#10038)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10040)
  docs/troubleshooting: upgrade docker: erroneous command (#10044)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Update Gitea Service index.md
2 participants