Add more information about active plugin changes to the event. - #2941
Open
Ottermandias wants to merge 3 commits into
Open
Add more information about active plugin changes to the event.#2941Ottermandias wants to merge 3 commits into
Ottermandias wants to merge 3 commits into
Conversation
Ottermandias
commented
Sep 1, 2026
Ottermandias
commented
Contributor
- I avoided to use IExposedPlugin since this contains data that does not make sense for a now-uninstalled plugin, and also references to objects that should only be available in a live plugin.
- So this creates most of the possibly relevant data and stores it without references, most importantly the WorkingPluginId, which is the only way to uniquely identify a plugin across its lifetime (due to dev plugins sharing internal names, possibly).
KazWolfe
requested changes
Sep 8, 2026
KazWolfe
left a comment
KazWolfe
left a comment
Member
There was a problem hiding this comment.
Couple API16 notes, please fix the indentation issues and I'd be happy to merge.
| public interface IActivePluginsChangedEventArgs | ||
| { | ||
| /// <summary> Contains a subset of the data of <see cref="IExposedPlugin"/> that is available even if the plugin has been unloaded. </summary> | ||
| public interface IAffectedPlugin |
Member
There was a problem hiding this comment.
[API16] we should probably clean up the types to create a clear(er) inheritance path between everything.
| public IEnumerable<IActivePluginsChangedEventArgs.IAffectedPlugin> AffectedPlugins { get; } | ||
|
|
||
| /// <inheritdoc/> | ||
| internal sealed class AffectedPlugin(LocalPlugin plugin, Version? version) : IActivePluginsChangedEventArgs.IAffectedPlugin |
Member
There was a problem hiding this comment.
[API16] Ditto; should be in the inheritance tree.
KazWolfe
approved these changes
Sep 8, 2026
KazWolfe
enabled auto-merge (squash)
September 8, 2026 16:01
KazWolfe
disabled auto-merge
September 8, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.