streaming: add stream TTL (absolute and sliding)#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds built-in TTL support for Redis streams in Pulse, configurable via stream options:
options.WithStreamTTL(ttl): absolute TTL (set once when the Redis key is created; never extended)options.WithStreamSlidingTTL(ttl): sliding TTL (refreshed on each publish)TTL is applied in both stream creation paths:
Stream.Add/XADD) — after the write succeedsnewSink/XGROUP CREATE ... MKSTREAM) — after the group/stream existsDocs: added a short “Stream retention (TTL)” section to
streaming/README.md.Why
Many production uses want automatic retention for per-run/per-session streams to avoid leaked keys accumulating indefinitely. Pulse already caps stream length via
MaxLen, but length trimming alone doesn’t guarantee eventual cleanup of inactive streams.How
TTL+TTLSliding.Stream.AddandnewSinkcall a shared internal helperapplyTTL:ExpireNX(set only if no TTL exists).Expire(refreshes TTL).NewStreamfails fast on negative TTL (ttl < 0).Behavioral notes
XADD), orMKSTREAM) even before the first event.Test evidence
go test ./streaming/options -run TestStreamOptionsgo test ./streaming -run TestOptionsTTL behavior tests live in
streaming/streams_test.goand require a Redis instance (e.g.localhost:6379).