Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align flags with the CreateMode registered on zookeeper libs #125

Conversation

alandiegosantos
Copy link

@alandiegosantos alandiegosantos commented Apr 2, 2024

The flags added were not aligned with the flags from zookeeper repo. This change aligns both to support the multiple CreateModes supported by zookeeper.

Refer to #119

@alxn
Copy link

alxn commented Apr 6, 2024

This is all so weird, I thought these were bit flags, and it sort of makes sense where:

EPHEMERAL(1,
PERSISTENT_SEQUENTIAL(2

1 | 2 == 3

EPHEMERAL_SEQUENTIAL(3

Though I guess "EPHEMERAL/PERSISTENT" is an oxymoron.

But otherwise I guess it makes sense.

alxn
alxn previously approved these changes Apr 6, 2024
@alxn alxn dismissed their stale review April 6, 2024 21:59

Notice build failure

@Mengyantong
Copy link

Yeah it makes sense by |, currently i used the CreateTTL well by changing my flags into zk.FlagTTL|zk.FlagEphemeral, I also thought it werid and asked the question on stackoverflow a month ago. 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants