-
Notifications
You must be signed in to change notification settings - Fork 56
zmq4: router recv returns error when closing context #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 54.37% 54.49% +0.12%
==========================================
Files 26 26
Lines 1933 1934 +1
==========================================
+ Hits 1051 1054 +3
+ Misses 784 781 -3
- Partials 98 99 +1
Continue to review full report at Codecov.
|
needs go-zeromq/license#3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking at this.
I have a couple of nit-picks but other than that, this looks fine.
(do I understand correctly that this also fixes #57
?)
I have cherry-picked your code and rebased over there: #72 thanks a lot. |
No description provided.