Skip to content

zmq4: router recv returns error when closing context #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

zmq4: router recv returns error when closing context #58

wants to merge 3 commits into from

Conversation

speakyourcode
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #58 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   54.37%   54.49%   +0.12%     
==========================================
  Files          26       26              
  Lines        1933     1934       +1     
==========================================
+ Hits         1051     1054       +3     
+ Misses        784      781       -3     
- Partials       98       99       +1
Impacted Files Coverage Δ
router.go 75.59% <100%> (+0.98%) ⬆️
conn.go 54.73% <0%> (-1.06%) ⬇️
utils.go 75% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ce94b...f3ef2d9. Read the comment docs.

@sbinet
Copy link
Contributor

sbinet commented Jan 19, 2020

needs go-zeromq/license#3

Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking at this.

I have a couple of nit-picks but other than that, this looks fine.
(do I understand correctly that this also fixes #57 ?)

sbinet pushed a commit to sbinet-alice/zmq4 that referenced this pull request Jan 24, 2020
@sbinet sbinet mentioned this pull request Jan 24, 2020
Merged
@sbinet sbinet closed this in a6ca866 Jan 24, 2020
@sbinet
Copy link
Contributor

sbinet commented Jan 24, 2020

I have cherry-picked your code and rebased over there: #72

thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants