-
Notifications
You must be signed in to change notification settings - Fork 56
add hello example #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hello example #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 67.40% 67.19% -0.21%
==========================================
Files 29 29
Lines 1813 1814 +1
==========================================
- Hits 1222 1219 -3
- Misses 490 493 +3
- Partials 101 102 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo the small nit-pick.
could you send another PR against go-zeromq/license adding yourself to the AUTHOR
and/or CONTRIBUTORS
files?
thanks.
Co-authored-by: Sebastien Binet <binet@cern.ch>
This is more like the original.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
(put please send another PR against go-zeromq/license adding yourself to the AUTHORS
and/or CONTRIBUTORS
files. then I'll merge this PR in)
Got it. I don't see an |
these files are in the |
Got that. Pull requests created. |
needs go-zeromq/license#10 and go-zeromq/license#11 |
thanks a lot and welcome to go-zeromq :) |
This is derived from https://zguide.zeromq.org/docs/chapter1/.