This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Fix simple key handling #1031
Closed
Fix simple key handling #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does anyone know if this PR will accepted and the release version for this feature? Thanks |
|
@AntoineJac I contacted the maintainer via email but got no answer. This project seems completely abandoned. But worth tagging @niemeyer , maybe we are lucky |
|
Sorry, I'm still here. I just haven't had the time to provide feedback and work on the project that is due. As I said elsewhere, I want to get a team to be responsible for this so it's not a one man show, but I've been failing to allocate that. As far as this PR is concerned, it seems reasonable, but it needs:
|
|
tried to fix this in #1037 |
|
Thank you @Tieske I think it is sensible to close this PR in favor of yours, since yours is more complete! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a key is more than 128 characters, it is handled as a complex mapping key, however this goes against the YAML spec as pointed out in #849 (comment) . Can be read here: https://yaml.org/spec/1.2.2/#flow-mappings
This causes issues when handling OpenAPI specifications with paths longer than 128 characters, making them invalid.
This PR aims to fix this issue, which is also affecting yq as can be seen here mikefarah/yq#1192
Fixes #849