go-yaml accepts invalid durations

[azylman]

When you call ParseDuration with an invalid duration (e.g. 15) it errors: https://play.golang.org/p/WAq-o3NT3D

However, if you use go-yaml and try to marshal an invalid duration such as 15 into a time.Duration, it accepts it and treats it as a number of nanoseconds.

test.yaml

thing: 15

test.go

package main

import (
        "io/ioutil"
        "log"
        "time"

        yaml "gopkg.in/yaml.v2"
)

type Spec struct {
        Thing time.Duration `yaml:"thing"`
}

func main() {
        data, err := ioutil.ReadFile("./test.yaml")
        if err != nil {
            panic(err)
        }

        var s Spec
        if err := yaml.Unmarshal(data, &s); err != nil {
            panic(err)
        }

        log.Printf("%#v", s)
}

output

2016/09/19 13:48:07 main.Spec{Thing:15}

[niemeyer]

This has changed as suggested in v3, so time.Duration won't accept decoding from ints.

Will close this once v3 is released.

[szyhf]

@niemeyer I think may be accept "0" as validate time.Duration and reject any other int is more convenience to use~

[gurza]

Unmarshaling of time.Duration works in v3, https://play.golang.org/p/-6y0zq96gVz