Skip to content

Commit

Permalink
net/http: use DOMException.message property in error text
Browse files Browse the repository at this point in the history
Previously, details about the underlying fetch error
were not visible in the net/http error text:

	net/http: fetch() failed: <object>

When using the message property, they are:

	net/http: fetch() failed: Failed to fetch
	net/http: fetch() failed: The user aborted a request.

Reference: https://developer.mozilla.org/en-US/docs/Web/API/DOMException/message.

Change-Id: Iecf7c6bac01abb164731a4d5c9af6582c250a1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/226205
Reviewed-by: Johan Brandhorst <johan.brandhorst@gmail.com>
  • Loading branch information
dmitshur committed Mar 29, 2020
1 parent 534f56b commit 7bfac4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/net/http/roundtrip_js.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func (t *Transport) RoundTrip(req *Request) (*Response, error) {
})
defer success.Release()
failure := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
err := fmt.Errorf("net/http: fetch() failed: %s", args[0].String())
err := fmt.Errorf("net/http: fetch() failed: %s", args[0].Get("message").String())
select {
case errCh <- err:
case <-req.Context().Done():
Expand Down

0 comments on commit 7bfac4c

Please sign in to comment.