fix: allow events yaml unmarshal #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 96.55% 96.08% -0.47%
==========================================
Files 69 69
Lines 5335 5361 +26
==========================================
Hits 5151 5151
- Misses 110 136 +26
Partials 74 74
|
wass3rw3rk
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
this should probably be added in https://github.com/go-vela/server/blob/main/api/types/repo.go as well now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets
allow_eventsbe unmarshalled as a string slice in yaml, primarily for the cli to read add/update input from a file.kudos @wsan3 for spotting the bug