Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mock): use correct api pkg for secret #1211

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(mock): use correct api pkg for secret #1211

merged 1 commit into from
Oct 18, 2024

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 18, 2024 16:12
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.35%. Comparing base (c701bd8) to head (1e1cd2d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files         590      590           
  Lines       32438    32438           
=======================================
  Hits        18279    18279           
  Misses      13530    13530           
  Partials      629      629
Files with missing lines Coverage Δ
mock/server/secret.go 0.00% <ø> (ø)

KellyMerrick
KellyMerrick approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit cb37db9 into main Oct 18, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/correct-mock-secret-type branch October 18, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @timhuynh94 @KellyMerrick @plyr4