refactor(secret): use server API types for secret #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -7,12 +7,13 @@ | |||
| "reflect" | |||
| "testing" | |||
|
|
|||
| "github.com/DATA-DOG/go-sqlmock" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s blank -s dot -s prefix(github.com/go-vela) --custom-order (gci)
| ) | ||
|
|
||
| // Create creates a new secret. | ||
| func (c *client) Create(ctx context.Context, sType, org, name string, s *library.Secret) (*library.Secret, error) { | ||
| func (c *client) Create(ctx context.Context, sType, org, name string, s *api.Secret) (*api.Secret, error) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
| ) | ||
|
|
||
| // Get captures a secret. | ||
| func (c *client) Get(ctx context.Context, sType, org, name, path string) (s *library.Secret, err error) { | ||
| func (c *client) Get(ctx context.Context, sType, org, name, path string) (s *velaAPI.Secret, err error) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 56.17% 55.17% -1.00%
==========================================
Files 584 586 +2
Lines 21291 31488 +10197
==========================================
+ Hits 11960 17374 +5414
- Misses 8717 13500 +4783
Partials 614 614
|
timhuynh94
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing refactor efforts. Only a few more!