Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oidc): image parse sha support #1207

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(oidc): image parse sha support #1207

merged 1 commit into from
Oct 15, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Oct 15, 2024

tiny fix for #1172 invalid reference format with sha tags

or should we use reference.Parse similar to the worker code

@plyr4 plyr4 requested a review from a team as a code owner October 15, 2024 04:20
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (67a8e47) to head (d10993f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   56.16%   56.17%           
=======================================
  Files         584      584           
  Lines       21288    21291    +3     
=======================================
+ Hits        11957    11960    +3     
  Misses       8717     8717           
  Partials      614      614           
Files with missing lines Coverage Δ
internal/token/mint.go 25.47% <100.00%> (+2.17%) ⬆️

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO may be to actually parse the SHA and make it a claim. Not all SHA digests are going to refer to latest

@ecrupper ecrupper merged commit b0e091f into main Oct 15, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the fix/oidc-image branch October 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants