Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade yaml library to go-yaml v3 over buildkite #1171

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Follow up from go-vela/types#386

And also fixing the tests that were broken from go-vela/types#387

@ecrupper ecrupper requested a review from a team as a code owner August 26, 2024 14:29
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (efd5b04) to head (f98f0b5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   52.91%   52.91%           
=======================================
  Files         550      550           
  Lines       19162    19162           
=======================================
  Hits        10139    10139           
  Misses       8459     8459           
  Partials      564      564           
Files Coverage Δ
api/types/string.go 85.71% <ø> (ø)
compiler/native/compile.go 71.63% <ø> (ø)
compiler/native/parse.go 86.51% <ø> (ø)
compiler/native/substitute.go 69.23% <ø> (ø)
compiler/template/native/convert.go 90.90% <ø> (ø)
compiler/template/native/render.go 85.71% <ø> (ø)
compiler/template/starlark/render.go 47.16% <ø> (ø)
mock/server/pipeline.go 0.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 0894432 into main Aug 26, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/yaml-upgrade branch August 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants