Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(queue): pop from inRoutes if supplied #1153

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner June 24, 2024 20:14
timhuynh94
timhuynh94 previously approved these changes Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.16%. Comparing base (71d4cfd) to head (cda3a32).

Current head cda3a32 differs from pull request most recent head 426175f

Please upload reports for the commit 426175f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   52.15%   52.16%   +0.01%     
==========================================
  Files         550      550              
  Lines       18833    18833              
==========================================
+ Hits         9822     9825       +3     
+ Misses       8447     8446       -1     
+ Partials      564      562       -2     
Files Coverage Δ
queue/redis/pop.go 82.60% <100.00%> (+13.04%) ⬆️

plyr4
plyr4 previously approved these changes Jun 24, 2024
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@ecrupper ecrupper dismissed stale reviews from plyr4 and timhuynh94 via cda3a32 June 24, 2024 20:22
wass3r
wass3r previously approved these changes Jun 24, 2024
go.mod Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit b24411e into main Jun 24, 2024
11 of 12 checks passed
@ecrupper ecrupper deleted the fix/queue/pop-routes branch June 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants