Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(mock): add dashboard responses from server in mock #1118

Merged
merged 6 commits into from
May 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 2, 2024

Will need for SDK testing

@ecrupper ecrupper requested a review from a team as a code owner May 2, 2024 20:09
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 67.60%. Comparing base (7693199) to head (2914dbf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   67.75%   67.60%   -0.16%     
==========================================
  Files         391      392       +1     
  Lines       13034    13063      +29     
==========================================
  Hits         8831     8831              
- Misses       3696     3725      +29     
  Partials      507      507              
Files Coverage Δ
mock/server/server.go 0.00% <0.00%> (ø)
mock/server/dashboard.go 0.00% <0.00%> (ø)

mock/server/dashboard_test.go Outdated Show resolved Hide resolved
mock/server/dashboard_test.go Outdated Show resolved Hide resolved
mock/server/dashboard.go Outdated Show resolved Hide resolved
mock/server/dashboard.go Outdated Show resolved Hide resolved
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 38cd714 into main May 6, 2024
11 of 12 checks passed
@ecrupper ecrupper deleted the dashboard-mock branch May 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants