fix(scm): skipped map to failure for step status + remove deploy #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 63.26% 63.27%
=======================================
Files 348 348
Lines 10600 10599 -1
=======================================
Hits 6706 6706
+ Misses 3409 3407 -2
- Partials 485 486 +1
|
timhuynh94
previously approved these changes
Mar 29, 2024
…nto fix/step-status/skipped
timhuynh94
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this comment from the original PR to have steps that are skipped report as failures.
Also ignoring deployment events for step status reporting. We report the build status to the deployment rather than the commit, and given that there are not multiple deployment statuses, it makes sense to just ignore. This also prevents status limits to the same commit if a repo rarely makes changes but deploys often.