fix: Print dotenv file path when there is an error reading file #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbitty
force-pushed
the
issue-1261_dotenv_error_message
branch
from
4e853fb
to
326e7f5
Compare
pbitty
commented
Sep 27, 2024
| expected := fmt.Sprintf("error reading env file %s:", path) | ||
|
|
||
| err := e.Setup() | ||
| require.ErrorContains(t, err, expected) |
There was a problem hiding this comment.
I used ErrorContains() and only included the part of the error message that we add, so that the tests wouldn't depend on the exact wording coming from the dotenv library.
|
Thanks! |
vmaerten
added a commit
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261.