Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Cannot use splitArgs and splitLines in for-loops #1823

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix: Cannot use splitArgs and splitLines in for-loops #1823

merged 4 commits into from
Sep 20, 2024

Conversation

stawii
Copy link
Contributor

@stawii stawii commented Sep 19, 2024 •
edited
Loading

Solves #1822

@stawii stawii mentioned this pull request Sep 20, 2024
Closed
pd93
pd93 requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. 1 small request though:

Can we add a case for []int too since we have functions like until and untilStep which will have the same issue.

@stawii stawii requested a review from pd93 September 20, 2024 16:25
pd93
pd93 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pd93 pd93 merged commit cb07189 into go-task:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 pd93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stawii @pd93